Looks good and works as before 👍

👍

seem mysql is not happy. I'll have a look tomorrow

1) Test\DB\ConnectionTest::testSetValuesOverWrite
570s
98
Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'INSERT INTO `oc_table` (`integerfield`, `textfield`) VALUES(?, ?)' with params [1, "bar"]:
570s
100
SQLSTATE[HY000]: General error: 1364 Field 'clobfield' doesn't have a default value

So this is a BC breaking minor update... great 🎉
Tables that need adjustments:

• appconfig: https://github.com/nextcloud/server/blob/master/db_structure.xml#L37-L41
• preferences: https://github.com/nextcloud/server/blob/master/db_structure.xml#L669-L673
• credentials: https://github.com/nextcloud/server/blob/master/db_structure.xml#L1946-L1950
• dav:

  server/apps/dav/appinfo/database.xml

  Lines 359 to 362 in 06e969c

  	<field>
  	<name>timezone</name>
  	<type>clob</type>
  	</field>

• user_ldap:

  server/apps/user_ldap/appinfo/database.xml

  Lines 128 to 132 in fe8bae3

  	<field>
  	<name>owncloudusers</name>
  	<type>clob</type>
  	<notnull>true</notnull>
  	</field>

• ... I stop here

I guess we need to fix the schema reader and hack it in. We can't break all these apps on 5.6 + mysql (I guess this is the greatest part of instances)

Mmm I must say I'm surprised this even worked before. But the big question is why did it work before and not anymore.

Ok so it fails now because of: https://github.com/nextcloud/3rdparty/pull/18/files#diff-f1134e2d70bff8e3d0e698f41c3a652bL111

Which is a line added by @MorrisJobke in doctrine/dbal@e73ef8b

But has no trace in the 2.5 branch aparently anymore.

Pushed 3rdparty patch lets see

Whee mysql is happy.

👍

Upps .. 3rdparty needs to be updated to current master -> @rullzer could you update this?